Feature/enum support - #2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds enum validation support to validateEnv, allowing schema entries to specify a set of allowed string values (e.g., NODE_ENV: ["development", "production", "test"]) and validating process.env against that set.
Changes:
- Extend the
Schematype to support enum rules (readonly string[]) and route those rules through a newparseEnumvalidator. - Add Vitest coverage for valid/invalid enum values and ensure
NODE_ENVis cleaned up between tests. - Export
EnumTypeand bump package version to0.2.0.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validate.test.ts | Adds tests for enum validation and invalid enum error behavior; cleans up NODE_ENV in beforeEach. |
| src/validators.ts | Introduces parseEnum to validate env var values against an allowed set. |
| src/validateEnv.ts | Extends schema handling to support enum rules via Array.isArray(rule) and parseEnum. |
| src/index.ts | Re-exports EnumType from the public API. |
| package.json | Bumps package version to 0.2.0. |
| package-lock.json | Updates lockfile version metadata to 0.2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adds enum validation support to validateEnv, allowing schema entries to specify a set of allowed string values (e.g., NODE_ENV: ["development", "production", "test"]) and validating process.env against that set.
Changes: