chore: bump fig-extract to v2.14.0#32
Conversation
soft 캡션 문서 게이트 강건화 — hardBody sep-증거 + 3-체제 라우터. ## 엔진 repo 게이트 (통과) gate 스코프(3편 promoted 편입, 104편): G0 pending 0 · G1 regressions 0 · G2 resolved 8/regressed 0 · sCritical 0.9218. 전수 diff v2.13.1↔v2.14.0 ADDED 15(전부 critical/nd: Hao 8·s10854 4·s11269 3)·REMOVED 0·MOVED 0. ## 소비자 영향 [계약 무변경] — extract() 시그니처·출력 필드 불변. fig-engine.ts·fig-extract.d.ts·integration.md 갱신 불요. typecheck exit 0 · build exit 0 · [사람] Margin 스모크 대기. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthrough엔진 버전을 2.14.0으로 올리고 soft 캡션 증거 집계와 ambiguous 승격을 변경했다. provisional 앵커의 up 점수를 검증해 낮은 점수 앵커를 강등하고 페이지를 재감지하며, 내부 앵커 태그는 최종 출력에서 제거한다. ChangesSoft 캡션 게이트 처리
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant extract
participant detectPageWithFloor
participant detectPage
participant assembleAnchors
extract->>detectPageWithFloor: 페이지 감지 요청
detectPageWithFloor->>detectPage: 초기 figure 감지
detectPage-->>detectPageWithFloor: provisional 앵커와 upScore_ 반환
detectPageWithFloor->>assembleAnchors: floor 미달 앵커 강등 및 재조립
assembleAnchors-->>detectPageWithFloor: 갱신된 앵커 구성
detectPageWithFloor->>detectPage: 갱신 구성으로 재감지
detectPageWithFloor-->>extract: 최종 figure 반환
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)src/core/fig-extract.jsast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/core/fig-extract.js (1)
206-221: 🚀 Performance & Scalability | 🔵 Trivial임계값 근거는 이미 자체 문서화됨 — 향후 재교정 트리거만 유의.
애매역 잠정승격 soft 앵커의 최소 up-점수는 애매역 phantom과 진짜 soft 캡션 사이 gap의 중앙값이며, 3편(reject 1 phantom + target 2 recover) 실측 기반 잠정치라는 한계가 주석에 명시되어 있습니다. 코드 자체엔 문제가 없으나,
hardBody==1애매역 문서가 코퍼스에 늘어나면SOFT_UP_FLOOR/SOFT_GATE_K재교정이 필요하다는 점을 운영 관점에서 계측(예: regime=ambiguous 발생 빈도 로깅)해두면 향후 회귀를 조기에 잡을 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/fig-extract.js` around lines 206 - 221, Instrument the soft document gate around SOFT_GATE_K and SOFT_UP_FLOOR to record how often the ambiguous regime (hardBody between 1 and SOFT_GATE_K - 1) occurs. Preserve the existing threshold behavior and use the project’s established logging or metrics mechanism so future corpus growth can trigger threshold recalibration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/core/fig-extract.js`:
- Around line 206-221: Instrument the soft document gate around SOFT_GATE_K and
SOFT_UP_FLOOR to record how often the ambiguous regime (hardBody between 1 and
SOFT_GATE_K - 1) occurs. Preserve the existing threshold behavior and use the
project’s established logging or metrics mechanism so future corpus growth can
trigger threshold recalibration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c964fc9-b3a7-447b-8b8a-12e2d20ce7e0
📒 Files selected for processing (1)
src/core/fig-extract.js
soft 캡션 문서 게이트 강건화 — 혼합-관습 문서서 hard 앵커 1개가 같은 문서 soft 캡션을 전량 몰살하던 문제 해결.
엔진 변경 (figure-preview-test v2.13.1 → v2.14.0)
hardBody로 교정 = (비-family sep 앵커) + (반복 동형 bare, 같은 form ≥2). 고립 bare 맨-라벨(캡션 라벨이 컬럼 wrap된 잔재)은 제외.hardBody3-체제 라우터 — 0 전량승격 / 1 애매역(잠정승격 → up-점수 floor 8.5 검증 → 강등 → detectPage 재실행 fixpoint) / ≥2 전량기각.엔진 repo 게이트 (통과)
gate 스코프(3편 promoted 편입, 104편): G0 pending 0 · G1 regressions 0 · G2 resolved 8 / regressed 0 · sCritical 0.9218.
전수 diff v2.13.1 ↔ v2.14.0: ADDED 15(전부 critical/not_detected 복구: Hao 8 · s10854 4 · s11269 3) · REMOVED 0 · MOVED 0.
검증: 3 subagent + 4-critic 적대검증 패널 + 적대 코드리뷰(BUG-minor 1 수정, 코퍼스 산출 Δ0 재검증).
소비자 영향
[계약 무변경]—extract()시그니처·출력 필드·좌표계·(num,page) 키·manifest 스키마 불변.fig-engine.ts·fig-extract.d.ts·integration.md갱신 불요.byte-identical copy from figure-preview-test
fig-extract.js(diff 0).🤖 Generated with Claude Code
Summary by CodeRabbit