Skip to content

chore: bump fig-extract to v2.10.2 - #28

Merged
onetwothr1 merged 1 commit into
devfrom
chore/bump-fig-extract-2.10.2
Jul 22, 2026
Merged

chore: bump fig-extract to v2.10.2#28
onetwothr1 merged 1 commit into
devfrom
chore/bump-fig-extract-2.10.2

Conversation

@onetwothr1

@onetwothr1 onetwothr1 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Vendor fig-extract v2.9.3 → v2.10.2 into src/core/fig-extract.js.

  • byte-identical with the engine repo (md5 8e984591…); algorithm changes live only in figure-preview-test.
  • All three releases are [계약 무변경] — no fig-engine.ts / fig-extract.d.ts changes required. Output fields, coordinate system, and (num,page) identity unchanged; bboxes are just tighter.
    • v2.10.0 — table-caption boundary (recognized as a crop boundary only; no table emission).
    • v2.10.1 — side-by-side column separation (same-baseline siblings).
    • v2.10.2 — offset side-by-side (baseline-mismatched siblings) via detected-figure region overlap.
  • docs/fig-extract-integration.md §주의사항: added a region-boundary refinement note.
  • typecheck + build pass · ✅ [사람] Margin smoke (figure/table tab scan + preview) OK.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 개선 사항

    • 엔진이 v2.10.2로 업데이트되었습니다.
    • 표 캡션을 보다 정확히 인식하여 표 내용이 figure 영역에 포함되는 문제를 개선했습니다.
    • 나란히 배치된 figure가 서로의 영역을 잘못 포함하던 문제를 수정해 각 figure를 캡션 기준으로 분리합니다.
    • figure 및 table의 경계가 더 정확하고 타이트하게 산출됩니다.
    • 기존 출력 필드, 좌표계 및 식별자 형식은 변경되지 않습니다.
  • 문서

    • 엔진 업데이트 및 경계 산정 개선 사항을 통합 문서에 반영했습니다.

Vendor fig-extract v2.9.3 -> v2.10.2 (byte-identical, md5 8e984591…).
All releases [계약 무변경] — no fig-engine.ts / fig-extract.d.ts changes.
v2.10.0 table-caption boundary, v2.10.1/2 side-by-side column separation.
integration.md §주의사항: added region-boundary refinement note.
typecheck + build pass; [사람] Margin smoke OK.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@onetwothr1
onetwothr1 requested a review from enu3379 as a code owner July 22, 2026 11:54
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9807fd01-16b0-48f7-8f30-727b8ee637bc

📥 Commits

Reviewing files that changed from the base of the PR and between 82721c0 and 993eeb9.

📒 Files selected for processing (2)
  • docs/fig-extract-integration.md
  • src/core/fig-extract.js

📝 Walkthrough

Walkthrough

엔진 버전이 2.10.2로 갱신되고, table 캡션 인식 및 side-by-side figure의 bbox 경계 보정이 추가되었다. 최종 출력에서 내부 필드가 제거되며, 새 캡션 판별 함수가 export된다.

Changes

Figure extraction boundary refinement

Layer / File(s) Summary
Table caption detection and scan stopping
src/core/fig-extract.js
Table 캡션 판별 규칙과 임계값을 추가하고, table 캡션을 만나면 up-scan 블록을 롤백해 table 본문이 figure에 포함되지 않도록 처리한다.
Side-by-side figure boundary clamping
src/core/fig-extract.js
동일 기준선 또는 세로로 겹치는 나란한 figure의 x범위를 sibling 캡션 컬럼 경계에 맞춰 보정한다.
Output contract and integration documentation
src/core/fig-extract.js, docs/fig-extract-integration.md
엔진 버전을 2.10.2로 갱신하고, dir_를 최종 출력에서 제거하며 isTableCaption을 export한다. bbox 경계 변경 사항도 문서화한다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: enu3379

Poem

당근을 문 캡션 토끼,
표와 그림 경계를 살폈네.
나란한 그림은 제 칸에,
bbox는 더 꼭 맞게.
새 엔진 버전과 함께
깡충, 깔끔하게 달려가네!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed v2.10.2로 fig-extract 벤더 업데이트를 정확히 요약해 변경 사항과 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-fig-extract-2.10.2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.44.1)
src/core/fig-extract.js

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@onetwothr1
onetwothr1 merged commit e60c15e into dev Jul 22, 2026
3 checks passed
@onetwothr1
onetwothr1 deleted the chore/bump-fig-extract-2.10.2 branch July 22, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant