Repository navigation
Reduce duplicated config to single; move to common AutoConfiguration - #359
Merged
Merged
Conversation
|
skjolber
marked this pull request as ready for review
August 28, 2026 15:26
skjolber
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates JWT header-to-issuer mapper bean configuration into the shared Spring module, ensuring consistent initialization across supported server integrations.
Changes:
- Centralizes mapper and decider bean creation.
- Removes duplicated bean definitions from Web, WebFlux, and gRPC configurations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
jwt-spring-common/.../JwtAutoConfiguration.java |
Adds shared mapper bean configuration. |
jwt-spring-web/.../JwtWebSecurityChainAutoConfiguration.java |
Removes duplicate Web configuration. |
jwt-spring-webflux/.../JwtWebFluxSecurityAutoConfiguration.java |
Removes duplicate WebFlux configuration. |
jwt-spring-grpc-native/.../JwtGrpcAutoConfiguration.java |
Removes duplicate gRPC configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stronger way to ensure fixed bean init order.