feat: Add support for service.selector override - #259
Open
Sokkenissen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utfordring:
Common chart hardkoder Service-selektoren til app:
<release-name>. Dette fungerer fint for enkle deployments, men blir en utfordring når flere Helm-releaser skal dele samme nettverkstrafikk.Eksempel: canary-deployments. Når vi deployer en pricingservice-canary ved siden av pricingservice, får canary-podene labelen app: pricingservice-canary som ikke blir valgt i rutingen. Det finnes ingen måte å rute produksjonstrafikk til canary-podene på uten å bruke manuell kubectl patch på Servicen, noe som introduserer RBAC-bekymringer rundt github service account, skjørhet rundt Helm-rekonsiliering og operasjonelt overhead ved hver canary-deploy og teardown.
Forslag til løsning:
Eksponerer service.selector som en valgfri overstyring. Når den er satt, erstatter den standard app: -selektoren fullstendig. Når den ikke er satt, er oppførselen uendret.
Dette lar et canary-chart deklarere sin egen selektor som matcher en felles label på tvers av både hoved- og canary-podene
Endringer:
Se gjerne over og si hva dere tenker.