Feat/rollback on workflow cancel - #119
Closed
Sokkenissen wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endringer som legger til automatisk Helm-rollback hvis en bruker kansellerer workflowen midt under en deployment-rollout.
Sjekker om det finnes et pending Helm-release (helm list --pending). Hvis ja, kjøres helm rollback tilbake til forrige aktive versjon. Hvis ikke, så gjør den ingenting ("Nothing to roll back").
Opprettet som egen composite action for å gjøre den enklere å teste.
Det er litt edge-case, men ikke uhørt at man som bruker observerer noen rariteter i loggen eller på Grafana under en rollout som ikke direkte feiler deployment, men som gjør at bruker har lyst til å stoppe rollout av tenkelig problematisk versjon. Prøver å kopiere hvordan Harness håndterer kansellerte workflows under en rollout.