Complete dcat:Dataset headers in all NetworkCode cimxml files - #322
Complete dcat:Dataset headers in all NetworkCode cimxml files#322benceszirbik wants to merge 18 commits into
Conversation
All 36 NetworkCode cimxml files across Belgovia, Espheim, Galia, Svedala, and DC-Espheim-Svedala now conform to the header structure in docs/HeaderExample.xml. Addresses issue #157 (langString usage). Changes applied to all files: - Removed unused xmlns:eumd namespace declaration - Added xmlns:dcatcim and xmlns:adms where missing - Added: dcatcim:alternativeVersionOf, dcterms:accrualPeriodicity, dcterms:hasPart, dcat:temporalResolution, dcatcim:preferredVersionOf, dcterms:references, dcterms:type, adms:versionNotes xml:lang="en" File-specific fixes: - Belgovia_CO: added dcat:endDate; fixed dcat:replaces -> dcterms:replaces - Belgovia_SIS: added dcterms:publisher and prov:wasGeneratedBy - Svedala_AS: fixed xmlns:dcat-cim -> xmlns:dcatcim; added xml:lang to dcterms:description and adms:versionNotes; added dcat:endDate - Svedala_FAP_PV: added dcterms:license and dcterms:requires; removed unused xmlns:eu; dcterms:type Activity preserved as-is Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: benceszirbik <bence.szirbik@griddigit.eu>
PowerShell wrote the file back with a different encoding, corrupting Swedish characters (Ä -> Ä). Restore correct UTF-8 content in the data section while keeping the header-only changes from the previous commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: benceszirbik <bence.szirbik@griddigit.eu>
Add dcterms:title to 4 Jotunheim IAM datasets that had dcterms:description but no title. Title follows the YYYYMMDD_IAM_HHMMZ_1.0.0 pattern used by sibling files. Signed-off-by: benceszirbik <bence.szirbik@griddigit.eu>
Data Instance IssuesThere is currently a mix of metadata issues and instance data issues. This list focuses only on the instance data issues. 1. Prefixes
2. Remove the
|
Per review comment #2: eumd is not part of the HeaderExample prefix set. Removed the xmlns:eumd declaration from Svedala_RAS_acceptance_proposal, Svedala-Belgovia_CO and Svedala-Espheim_RA, and dropped the eumd:applicationSoftware element from Svedala_RAS_acceptance_proposal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per review comment #3, these properties shall not appear in any instance file header and are removed from all NetworkCode cimxml datasets: - dcatcim:alternativeVersionOf - dcterms:accrualPeriodicity - dcterms:hasPart - dcat:temporalResolution - dcatcim:preferredVersionOf (dcat:inSeries was not present in any file.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per review comment #1, instance files shall only use the prefixes from docs/HeaderExample.xml. Removed the now-unused xmlns:dcatcim declaration from all NetworkCode cimxml files (its only uses were the properties removed for review #3), and dropped the non-standard xmlns:euvoc and xmlns:md declarations from Svedala-Espheim_RA. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per review comment #13, publisher URIs shall follow https://energy.referencedata.eu/test/party/<PREFIX-Name> with TSO- for transmission system operators and RCC- for coordination centres: - test/party/Belgovia -> test/party/TSO-Belgovia - test/party/Espheim -> test/party/TSO-Espheim - test/party/Galia -> test/party/TSO-Galia - test/party/Svedala, Test/Party -> test/party/TSO-Svedala - test/party/JOTUNHEIM -> test/party/RCC-Jotunheim (Jotunheim is RCC) Also fixed Svedala-Espheim_RA, where dcterms:publisher pointed at a profile URI (ap.cim4.eu/RemedialAction/2.4) instead of a party; set to TSO-Svedala. Left as-is pending clarification: DC-Espheim-Svedala_CO uses test/party/DC-Espheim-Svedala, which is neither a TSO nor an RCC party. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per review comment #18, every instance file shall carry <dcterms:type rdf:resource="https://energy.referencedata.eu/type/CIM-PowerSystemModel"/>. Changed Svedala_FAP_PV from .../type/Activity, and added the property to Svedala-Espheim_RA and Svedala-Belgovia_CO, which were missing it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…#7/#12/#15/#19) This DC dataset header was missing several mandatory fixed-value fields. Added: - dcterms:accessRights = Confidentiality/Public (review #5) - xml:lang="en" on dcterms:description (review #7) - dcterms:license = CC BY 4.0 (review #12) - dcterms:rights / dcterms:rightsHolder (review #15) - adms:versionNotes xml:lang="en" (review #4) - dcat:version 1 -> 1.0.0 (review #19) Still open in this file (tied to deferred scheme work): the malformed prov:wasGeneratedBy value and prov:references usage - see review #14/#21. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Added xml:lang="en" to the adms:versionNotes element (all versionNotes shall be language-tagged) and corrected the "Inital" typo to "Initial". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Power Schedule dataset's title read 20220615_Belgovia_AE_1.0.0; corrected the profile token to _PS_. Full title/filename normalisation per review #22/#23 is deferred pending the naming inputs (publisher party, spatial, activity) that depend on the reference-scheme work. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks for the detailed list. I've pushed fixes for everything that was mechanical or had an explicit target value — eight commits on
Before I touch points 6, 10, 16, 21, I need to know your plans for the reference data, because the current schemes don't yet contain entries for most of our parties/frames/models/activities, so I can't "validate against" them without inventing values. Specifically:
Related, also blocked on the above:
Once you confirm the scheme extensions (or point me at where they'll live), I'll do points 6/10/16/21, the remaining point 13 party entries, point 14, and the points 22/23 rename pass. |
Extends review comment #2 beyond the NetworkCode cimxml headers: the eumd (Metadata-European) prefix is not part of the HeaderExample set and was declared but unused across the repository. Removed the dangling xmlns:eumd / PREFIX eumd declarations from all Instance XML and TriG files (Grid, NetworkCode, GridSituation, boundaryData, commonData, including the Jotunheim IAM/SAR files and the Belgovia CO version files). In the only two files that actually used it - Svedala_RAS_proposal.trig and Svedala_RAS_acceptance_proposal.trig - also removed the eumd:applicationSoftware statement and reterminated the preceding predicate block. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The ImpactAssessmentMatrix conformsTo URI had a stray double quote
(".../2.4""/>"), which made the file invalid XML. Removed the extra
quote. Note: the same broken value has propagated into the generated
Jotunheim NetworkCode/GridSituation manifest.ttl files (as ...2.4\"),
which should be regenerated from the corrected instance.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Added the mandatory <dcterms:type rdf:resource="https://energy.referencedata.eu/type/CIM-PowerSystemModel"/> to the Jotunheim IAM/SAR (NetworkCode) datasets and the Belgovia CO version files, which were all missing it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
All datasets shall carry a language-tagged adms:versionNotes. Added the xmlns:adms declaration and an adms:versionNotes xml:lang="en" element to the Jotunheim IAM/SAR (NetworkCode) datasets and the Belgovia CO version files, which were missing both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The SAR datasets declared xmlns:dcterms="http://purl.org/dc/terms/#" (trailing #), which makes every dcterms:* term resolve to the wrong IRI (.../terms/#accessRights instead of .../terms/accessRights). Corrected to http://purl.org/dc/terms/ in both the NetworkCode and GridSituation copies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Follow-up — widened scope (eumd + Jotunheim/Belgovia-version files) Pushed six more commits:
Two correctness bugs fixed along the way:
Newly-surfaced items for these files, still blocked on the reference-data decisions above:
One question: |
Sveino
left a comment
There was a problem hiding this comment.
I have made some comments - but not run through all the files. After we have made all the update to the dcterms:title we need to update the file name (and remove the dateTime).
| @@ -31,6 +31,9 @@ | |||
| <prov:wasGeneratedBy rdf:resource="https://energy.referencedata.eu/Activity/CGM-AE"/> | |||
| <dcterms:spatial rdf:resource="https://energy.referencedata.eu/Test/Frame/Belgovia-Power-Transmission-System"/> | |||
There was a problem hiding this comment.
| <dcterms:spatial rdf:resource="https://energy.referencedata.eu/Test/Frame/Belgovia-Power-Transmission-System"/> | |
| <dcterms:spatial rdf:resource="https://energy.referencedata.eu/Test/Frame/Belgovia-Transmission"/> |
In the Frame https://github.com/entsoe/relicapgrid/blob/cgmes-3.0_ncp-2.4_tc-1.1/Instance/referenceData/NetworkCode/cimxml/Test-FrameScheme-NCP_RD.xml
we shorten it to "-Transmission" - this apply to all.
| <dcterms:rightsHolder>ENTSO-E</dcterms:rightsHolder> | ||
| <dcterms:requires rdf:resource="urn:uuid:886d71fa-6ca7-4be9-a55d-04c3c49c987c"/> | ||
| <dcat:startDate>2025-05-18T18:00:00Z</dcat:startDate> | ||
| <dcterms:title>20250520_Belgovia_CO_1.0.0</dcterms:title> |
There was a problem hiding this comment.
| <dcterms:title>20250520_Belgovia_CO_1.0.0</dcterms:title> | |
| <dcterms:title>202505181800_TSO-Belgovia_SR-CO</dcterms:title> |
The first date should match the dcat:startDate (but not sure why it start at 18:00, Structural data should only change on a daily resolution. SR-CO is following the activity naming standard. When it is version 1.0.0 we do not need to include this - as this is the default.
| <dcterms:spatial rdf:resource="https://energy.referencedata.eu/Test/Frame/Belgovia-Power-Transmission-System"/> | ||
| <dcterms:issued>2025-05-18T18:00:00Z</dcterms:issued> | ||
| <dcat:endDate>2026-05-18T18:00:00Z</dcat:endDate> | ||
| <dcterms:references rdf:resource="urn:uuid:886d71fa-6ca7-4be9-a55d-04c3c49c987c"/> |
There was a problem hiding this comment.
| <dcterms:references rdf:resource="urn:uuid:886d71fa-6ca7-4be9-a55d-04c3c49c987c"/> | |
| <dcterms:requires rdf:resource="urn:uuid:886d71fa-6ca7-4be9-a55d-04c3c49c987c"/> |
There was a problem hiding this comment.
we should use dcterms:requires rather than dcterms:references - we might need to update some to dcterms:references later.
I do see that some is change to requires - so it could be that this is correct.
| @@ -20,7 +20,7 @@ | |||
| <dcat:isVersionOf rdf:resource="https://energy.referencedata.eu/Test/Model/Belgovia-ER"/> | |||
There was a problem hiding this comment.
| <dcat:isVersionOf rdf:resource="https://energy.referencedata.eu/Test/Model/Belgovia-ER"/> | |
| <dcat:isVersionOf rdf:resource="https://energy.referencedata.eu/Test/Model/TSO-Belgovia_SR-ER"/> |
|
Applied the changes:
|
Complete dcat:Dataset headers in all NetworkCode cimxml files
All 36 NetworkCode cimxml files across Belgovia, Espheim, Galia, Svedala,
and DC-Espheim-Svedala now conform to the header structure in
docs/HeaderExample.xml. Addresses issue #157 (langString usage).
Changes applied to all files:
dcterms:hasPart, dcat:temporalResolution, dcatcim:preferredVersionOf,
dcterms:references, dcterms:type, adms:versionNotes xml:lang="en"
File-specific fixes:
dcterms:description and adms:versionNotes; added dcat:endDate
unused xmlns:eu; dcterms:type Activity preserved as-is