fix(ci): upload the DocC archive as a tarball - #13
Merged
Conversation
The release of 0.1.0 went red on the documentation job. DocC names its files after the symbols they document, so `validate(_:)` becomes a path containing a colon, and upload-artifact refuses a colon because the artifact has to unpack on Windows too. 386 files, one character, the whole release red -- while the job that decides whether the tag means anything had passed. The archive is now packed with tar before it is uploaded. Also changed if-no-files-found from warn to error. It was set to warn, so a documentation job that produced nothing at all would have uploaded nothing and reported success. The job would then only ever fail for the reason it just did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release of
0.1.0went red on the documentation job:DocC names its files after the symbols they document, so
validate(_:)becomes apath containing a colon.
upload-artifactrefuses a colon because the artifacthas to unpack on Windows too. One character in a file name, and the whole release
reads as failed — while
Everything must be green before a tag means anything,the job that decides whether the tag means anything, had passed.
The archive is now packed with
tarbefore upload.Also:
if-no-files-foundwaswarn. A documentation job that producednothing at all would have uploaded nothing and reported success — so the job
could only ever fail for the reason it just did. It is now
error.