Don't crash when a tracked file is missing (#88)#99
Merged
Conversation
Moving or renaming a source markdown file left a stale entry in the filedb pointing at a path that no longer exists. `FileDB.changed_files` then called `fs[Path(p)]` on it, raising `FileNotFoundError` and crashing `sync`/`watch`. Treat a tracked file that is no longer on disk as changed, so a moved or deleted source surfaces as a change (triggering a re-tangle) instead of throwing. Adds a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jhidding
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving or renaming a source markdown file left a stale entry in the filedb pointing at a path that no longer exists.
FileDB.changed_filesthen calledfs[Path(p)]on it, raisingFileNotFoundErrorand crashingsync/watch.Treat a tracked file that is no longer on disk as changed, so a moved or deleted source surfaces as a change (triggering a re-tangle) instead of throwing.
Adds a regression test.
Notable finding: this issue and #96 are complementary. With only the #88 fix, a rename no longer crashes but then trips the #96 false-positive conflict (the annotation comment changes from <<test.md…>> to <<not-test.md…>> while the renamed source is older). I verified that with both fixes applied, a source rename works fully cleanly (test.c correctly re-references not-test.md, exit 0). So once both PRs land, "move a source file" works end-to-end. The two branches are independent, so they can be reviewed/merged in either order.