Fix #393#394
Conversation
After f6abb66, classpath read from bootstrap classpath file must be splitted into a list before to be passed to _start_process. Signed-off-by: Nick Diego Yamane <nick.diego@gmail.com>
|
Hi Nick, thank you for identifying and fixing this. All this stuff is getting pretty fiddly though especially since the Windows path fix changes, I didn't see those very closely when they were first added. Would you mind trying to add a test or two covering this? There are some existing tests for the launcher. I know that actually testing execution of the |
|
Side note: we need to figure out why our CI build isn't working properly. There was some issue when Drone infrastructure was moved a few months back, I don't know that it got specifically resolved but now builds apparently run yet don't actually do anything… maybe it's a new version of Drone and we have an old config format, or something. |
|
Hi @ches, Thanks for the quick feedback. |
After f6abb66, classpath read from
bootstrap classpath file must be splitted into
a list before to be passed to _start_process.
Signed-off-by: Nick Diego Yamane nick.diego@gmail.com