fix: strip nested child config recursively at assembly - #474
Open
Devil1716 wants to merge 1 commit into
Open
Conversation
Top-level CHILD_STRIP_APPARATUS left nested config inside section.content intact, and config-discovery still read it as document config. Recurse the strip so the master-only rule holds everywhere. Fixes enscribejs#472. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meta/configduring assembly (not just top-level kids)strict-modeoverride markers for nested declarationssection.contentconfigFixes #472
Test plan
node -e "import('./test/child-config-strip.test.js').then(m => m.run())"in packages/enscribe