Repository navigation
Fix BrokenProcessPool in tests + don't commit empty store on failed reprocess - #3
Merged
Conversation
…eprocess Two fixes in the pipeline runner: 1. Use a 'spawn' multiprocessing context for ProcessPoolExecutor so workers don't inherit the parent's thread state (icechunk's tokio runtime, aiohttp clients). Fork+threads was causing BrokenProcessPool in the integration test suite when test_reprocess_replaces_data ran after tests that left background threads alive in the parent. 2. When reprocess=True clears the store and zero frames subsequently succeed, raise instead of falling through to commit. Previously the cleared session would still be committed, leaving an empty store as the tip of main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the pipeline runner:
Use a 'spawn' multiprocessing context for ProcessPoolExecutor so workers don't inherit the parent's thread state (icechunk's tokio runtime, aiohttp clients). Fork+threads was causing BrokenProcessPool in the integration test suite when test_reprocess_replaces_data ran after tests that left background threads alive in the parent.
When reprocess=True clears the store and zero frames subsequently succeed, raise instead of falling through to commit. Previously the cleared session would still be committed, leaving an empty store as the tip of main.