gateway: Fix handshake log - #75
Conversation
WalkthroughAdjusted logging in DTLS handshake error path in gateway/gateway.go to emit Error-level logs with the actual error while preserving control flow. Updated version.txt from 0.8.0 to 0.8.1. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
gateway/gateway.go (1)
183-186: Broaden DTLS handshake error match and standardize log messageFile: gateway/gateway.go Lines: 183-186
- if _, ok := err.(*dtls.HandshakeError); ok { - gw.log.Error("Client TLS handshake error: %s", err) + var hsErr *dtls.HandshakeError + if errors.As(err, &hsErr) { + gw.log.Error("Client DTLS handshake error: %v", err) continue }Add import "errors" if missing. If handshake failures are noisy (e.g., port scans), consider lowering to WARN or sampling logs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
gateway/gateway.go(1 hunks)version.txt(1 hunks)
🔇 Additional comments (1)
version.txt (1)
1-1: Approve version bump — verification incomplete (rg skipped files)0.8.1 bump approved; the ripgrep run returned "No files were searched", so I couldn't confirm there are no lingering "0.8.0" references. Re-run verification with:
git ls-files -z | xargs -0 rg -n --no-ignore -S '0.8.0' -C1
Summary by CodeRabbit
Refactor
Chores