Theme: Set it as default for the whole project#2343
Open
manuq wants to merge 4 commits into
Open
Conversation
Otherwise, each Control scene has to set the theme to a root node for viewing it correctly in the editor, while the game doesn't need it. Remove duplicate themes in the StoryBook. Instead, new theme variation or theme overrides should be used.
Collaborator
Author
|
Draft for now because I spotted that the sign panel wasn't using our theme: Also the StoryBook has regressed. It was using 2 custom themes in 2 nodes, that were a duplicate of our theme: 
|
|
Play this branch at https://play.threadbare.game/branches/endlessm/global-theme/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
In the theme, rename the FixedSizeLabelContainer variant to FlatContainer. And use it for the sign. Also, add placeholder text to the sign so it can be seen in the editor.
As in the default theme. Add 16px margin override to some of these containers. The InputHUD and the similar control with input hints in the pause overlay weren't using the Threadbare theme, so they looked odd with 16px margin in all sides.
This is what the custom theme was doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, each Control scene has to set the theme to a root node for viewing it correctly in the editor, while the game doesn't need it.
Remove duplicate themes in the StoryBook. Instead, new theme variation or theme overrides should be used.