Fix build when no release exists - #92
Merged
Merged
Conversation
When no release exists, the default branch is placed at the root of the site:
if is_default and not have_toplevel_build:
branch_dir = dest_dir
branches_dir is a child of dest_dir:
branches_dir = dest_dir / "branches"
By default, x.relative_to(y) fails if x is a parent of y:
ValueError: '/home/runner/work/_actions/endlessm/amalgamate-pages/v2/_build'
is not in the subpath of
'/home/runner/work/_actions/endlessm/amalgamate-pages/v2/_build/branches'
This is a security feature. However in this case, as in a couple of other places
in the script, it is correct to use walk_up=True to allow using "../" in the path.
Resolves #91
Member
Author
|
@manuq FYI I think this will fix your piqui-piqui issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no release exists, the default branch is placed at the root of the site:
branches_dir is a child of dest_dir:
By default, x.relative_to(y) fails if x is a parent of y:
This is a security feature. However in this case, as in a couple of other places in the script, it is correct to use walk_up=True to allow using "../" in the path.
Resolves #91