chore: bump criterion 0.5 -> 0.8#16
Merged
Merged
Conversation
Replace deprecated criterion::black_box with std::hint::black_box. Refs #15.
rubenhensen
approved these changes
May 11, 2026
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
criterion0.5 → 0.8 (dev-dep). Replaces deprecatedcriterion::black_boxwithstd::hint::black_boxin benches.Refs #15.
Why this PR is small
The tracking issue lists nine outdated direct/dev deps. After investigation, only this one is straightforward to land right now. The rest are blocked or risky:
criterion0.5 → 0.8bincode2 → 3bincode 3.0.0on crates.io is an intentionalcompile_error!tombstone (see bincode-org/bincode#774). The real successor is unstable / under another name. Stay on 2 for now.rand_core0.6 → 0.10curve25519-dalek 4.x(latest stable: 4.1.3) pinsrand_core 0.6forScalar::random/OsRng.curve25519-dalek 5.0-pre.6is the only release wired torand_core 0.10and is still pre-release.rand0.8 → 0.10 (dev)rand 0.10re-exportsrand_core 0.10::RngCore, which doesn't satisfysetup/keygen/sign'sRngCore + CryptoRngbound (which still resolves torand_core 0.6). The doctest and benches all flowthread_rng()into those bounds.sha30.10 → 0.11sha3 0.11needsdigest 0.11.Scalar::from_hashingg.rs:233and thecurve25519-dalek/digestfeature are ondigest 0.10, so theSha3_512/Scalarboundary breaks. Lands with the curve25519-dalek 5 bump.bincode2 → 3 (dev),rand_xorshift0.3 → 0.5 (lock),csv1.1 → 1.4 (lock),sha20.9 → 0.11 (lock)rand_core 0.10/digest 0.11land.So the realistic plan is: wait for
curve25519-dalek5.0 stable, then do a single cross-cutting bump (rand + rand_core + sha3 + digest + curve25519-dalek 5). I'll re-evaluate when that ships.Verified locally
cargo build --all-featurescargo test --all-features(15 tests + 1 doctest pass)cargo bench --no-run --all-featurescargo fmt --all -- --checkcargo build --target wasm32-unknown-unknown --all-features --lib(no-std)Reviewer quickstart
```bash
git fetch origin && git checkout chore/dep-bumps && cargo test --all-features
```