chore: remove internal architecture docs from public .github#133
Merged
pdodgen-revparts merged 1 commit intoJun 17, 2026
Merged
Conversation
These were committed during DEVEX-1628 and DEVEX-1630 work and describe internal CI architecture, repo layouts, secret names, and workflow details. .github is a public repo; this content should not have landed here. Removing from main per DEVEX-1659 follow-up. Working copies of these docs remain available in the assignee's local working tree. Note: history retains the deleted files. Path A (delete-from-main only) was chosen over full history rewrite because (a) the content is not credentials, just architecture detail, and (b) history rewrite is heavy and incomplete (GitHub retains deleted commits by SHA for ~90 days, forks keep history, third-party crawlers may have indexed already).
PR SummaryLow Risk Overview No workflow, code, or config files change; only markdown is removed from the default tree so internal repo names, secret identifiers, and CI rollout detail are no longer browsable on this public repository. Reviewed by Cursor Bugbot for commit 7c61545. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes four internal architecture documents that were committed to this public repo during DEVEX-1628 and DEVEX-1630 work:
docs/superpowers/plans/2026-06-08-unify-php-build-workflows.mddocs/superpowers/plans/2026-06-10-common-bump-build-on-nightly.mddocs/superpowers/specs/2026-06-08-unify-php-build-workflows-design.mddocs/superpowers/specs/2026-06-10-common-bump-build-on-nightly-design.mdThese files contain internal CI architecture details, specific service repo names, secret names (
REPO_WRITE_PAT), and direct line-anchored references to workflow files. Not credentials, but legitimately internal — they shouldn't live on a public repo.Approach: delete from main only
History retains the deleted files. We chose this over full history rewrite because:
If a stronger erasure is wanted later (e.g. cred-level scrub),
git filter-repo --invert-paths --path docs/superpowers/+ force-push is the followup, but should be done as a separate explicit decision.Going forward
Internal architecture docs should land in private repos, not here. Going to recommend on DEVEX-1659 that future plans live in the (now-renamed)
encodium/actionsprivate repo, or in a dedicated internal-docs repo.