feat(api): type protocol role records#1482
Open
LiranCohen wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$role: truepaths asProtocolRolePathsand requirerecipientfor role-record creates at both the type and runtime boundariesCloses #1458.
Test plan
bun run build(packages/api)bun run --filter @enbox/protocols build && bun run --filter @enbox/browser buildbun test tests/typed-protocol.spec.ts -t 'protocol role records'bun test tests/audience-key-delivery.spec.ts -t 'forward recipientRolePublicKey on typed create'bun run lintFull integration coverage runs in CI.