Skip to content

fix(api): carry roles through typed reads and deletes#1472

Merged
LiranCohen merged 3 commits into
mainfrom
feat/typed-role-read-delete
Jul 24, 2026
Merged

fix(api): carry roles through typed reads and deletes#1472
LiranCohen merged 3 commits into
mainfrom
feat/typed-role-read-delete

Conversation

@LiranCohen

@LiranCohen LiranCohen commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose from and protocolRole on typed record reads and protocolRole on typed record deletes
  • forward the invoked protocol role through remote reads and deletes, including delegate-grant selection
  • retain the invoked role on returned records so repeated lazy data reads use the same authorization
  • document remote nested reads/deletes with { from, protocolRole, within } and clarify what Record.protocolRole retains

Closes #1467.

Test plan

  • isolated current-head remote role read/delete integration test (10 passing)
  • typed protocol suite (72 passing)
  • API dependency build and contract type-check
  • Agent build and full Agent suite (1,675 passing, 18 skipped)
  • bun run lint

@sonarqubecloud

Copy link
Copy Markdown

@LiranCohen

Copy link
Copy Markdown
Contributor Author

Addressed the review note in 3c3612c2 and brought the branch current with main without rewriting history.

  • corrected the multiline test object's visual alignment;
  • added concise remote nested read/delete examples using { from, protocolRole, within } to the exported request types;
  • corrected Record.protocolRole documentation to describe the role carried by the producing request and reused by follow-up operations.

Verification: typed protocol tests 72/72, root/API lint, API build and contract typecheck, Agent build, and the full Agent suite (1,675 passing, 18 skipped). CI is fully green, including Sonar and CodeQL.

@LiranCohen
LiranCohen merged commit 33dba16 into main Jul 24, 2026
28 checks passed
@LiranCohen
LiranCohen deleted the feat/typed-role-read-delete branch July 24, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(api): carry protocol roles through typed reads and deletes

1 participant