fix(dwn): revalidate records subscription authority#1471
Merged
Conversation
Contributor
Author
|
Addressed the validated review findings in
The stale subscription Q&A was updated. The two pre-existing neighboring gaps are tracked separately as #1474 and #1475. Targeted verification: 48 RecordsSubscribe tests, 87 Records Query/Count tests, 17 delivery/cross-protocol tests, root lint, DWN SDK build, and Agent build are green. Full matrix is running in CI. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
RecordsSubscribeopensProtocol policy remains pinned to the signed subscription timestamp. A later protocol reconfiguration does not reinterpret an already-authorized request; current role membership is still checked for every matching event.
Test plan
RecordsSubscribeHandlersuite (48 passing)bun run lint(18 packages)bun run --filter @enbox/dwn-sdk-js buildbun run --filter @enbox/agent build