NXT-12133: Added stickTo prop for Scroller and VirtualList fo fixed focus position#371
Open
daniel-stoian-lgp wants to merge 5 commits into
Open
NXT-12133: Added stickTo prop for Scroller and VirtualList fo fixed focus position#371daniel-stoian-lgp wants to merge 5 commits into
daniel-stoian-lgp wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
+ Coverage 82.06% 82.48% +0.41%
===========================================
Files 153 153
Lines 7506 7529 +23
Branches 2261 2272 +11
===========================================
+ Hits 6160 6210 +50
+ Misses 1041 1026 -15
+ Partials 305 293 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
There is an Ux requirement to allow fixed focus position on the screen when scrolling
Resolution
Added stickTo prop for Scroller and VirtualList - When set to
'start'anddirectionis'horizontal', moving focus with 5-way keys keeps the focus indicator at a fixed slot near the start (left in LTR, right in RTL) edge of the scroller and scrolls the list so the newly focused item lands in that slot. At the end of the list, when the item can no longer reach the fixed slot, the list scrolls only to its last position so the focused item stays visible.Additional Considerations
Links
NXT-12133
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)