Repository navigation
Fill an order's blanks from the holder's reservation row - #169
Merged
Merged
Conversation
The reservations sheet was only used to drop holders who had ordered;
nothing it knew reached the order. An order (sheet row or curated
addition) now takes its BLANK reservation date and location from the
same username's first reservations-sheet row, and the R1 owner/model
pair when it has neither answer. Never overwrites: the orders sheet and
overrides.yaml stand (the two sheets' reservation dates disagree for
39 of 244 matched orders). Runs after curation, before parsing, so a
filled value is cleaned like the rest.
Each fill is listed under "Filled from reservations" in the
data-quality panel's "Added or corrected" group. The reservations
sheet's R1 columns are now mapped (schema.yaml).
The reservation audits also name the other row: a duplicate says which
row was kept ("repeat of #2 (kept)"), a converted reservation names its
order ("already an order (#495)", or "added in overrides.yaml").
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🔎 Preview deployLatest build: https://pr-169.r2-dashboard.pages.dev — always the newest build for this PR. Production (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the reservations sheet was only used to drop holders who had already ordered. Nothing it recorded reached the order. This came up curating KCSF: the curated addition matched their reservation but didn't pick up its location.
Fill blanks from the holder's reservation row
reconcile_r1_owner).overrides.yamlgives stands. Where both sheets give a reservation date, they disagree for 39 of 244 matched orders, and nothing says which is right.schema.yaml.Reservation audits name the other row
repeat of #2 (kept).already an order (#495), or(added in overrides.yaml)when it matched a curated addition.Tests
New tests cover:
./ci_env lintand the JS checks pass, and so does every Python test excepttest_overrides_yaml_is_canonical. That one failed only against my local, uncommittedoverrides.yamledits (not yet sorted); the committed file is canonical.