Skip to content

Types does not recognize IndexAssetInfo type #70

Open

Description

@centerpeas

When loading all weighted indexes, after making the multicall to get all data it then tries to transform each type in this function:

https://github.com/empyrealapp/eth-packages/blob/main/packages/eth_rpc/src/eth_rpc/utils/types.py#L26

While iterating over, it tries to process:

list[eth_typeshed.peapods.weighted_index.IndexAssetInfo]

which it catches as a list and tries to then process the IndexAssetInfo class

https://github.com/empyrealapp/eth-packages/blob/main/packages/eth_typeshed/src/eth_typeshed/peapods/weighted_index.py#L10

but the transform function gets stuck in an infinite loop as it does not appear to have a catch for IndexAssetInfo's type

Activity

  1. johnny-emp commented on Nov 5, 2024

    @johnny-emp
    Contributor

    hey sorry for the delay! thanks for pointing this out, we need to migrate this from a NamedTuple to a Struct. Let me take a look at this and i'll get back to you. Do you think you could provide a minimal reproducible example of how you're running this? A gist or something simple would be really helpful

  2. johnny-emp commented on Nov 25, 2024

    @johnny-emp
    Contributor

    @centerpeas just wanted to follow up on this, do you have a small example of how you're running this?

  3. johnny-emp commented on Dec 7, 2024

    @johnny-emp
    Contributor

    @centerpeas I believe this fixes the issue #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions