Skip to content

A11Y Improvements: Add Alt Attribute from Post Metadata Or Default to Empty Value #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayjayjpg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

A11Y Improvements: Add Alt Attribute from Post Metadata Or Default to Empty Value #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion addon/templates/components/post-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

{{#if @post.image}}
{{#link-to 'post' @post.id class="post-card-image-link"}}
<ResponsiveImage class="post-card-image" @image={{responsive-image-url @post.image}} />
<ResponsiveImage
class="post-card-image"
@image={{responsive-image-url @post.image}}
alt={{if post.imageMeta.alt post.imageMeta.alt ""}} />
{{/link-to}}
{{/if}}

Expand Down
4 changes: 3 additions & 1 deletion app/templates/page.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ into the {body} of the default.hbs template --}}

{{#if post.image}}
<figure class="post-full-image">
<ResponsiveImage @image={{responsive-image-url post.image}} />
<ResponsiveImage
@image={{responsive-image-url post.image}}
alt={{if post.imageMeta.alt post.imageMeta.alt ""}} />
</figure>
{{/if}}

Expand Down
4 changes: 3 additions & 1 deletion app/templates/post.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ into the {body} of the default.hbs template --}}

{{#if post.image}}
<figure class="post-full-image">
<ResponsiveImage @image={{responsive-image-url post.image}} />
<ResponsiveImage
@image={{responsive-image-url post.image}}
alt={{if post.imageMeta.alt post.imageMeta.alt ""}} />
</figure>
{{/if}}

Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/advanced-markdown.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/advanced.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- ghost
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/ember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/ember.jpg
imageMeta:
attribution: by Robert Wagner
attributionLink: https://unsplash.com/photos/OM4TjQwHC1I
alt: Wooden desk with a laptop and a screen showing the Ship Shape Logo. The desk features several EmberJS mascot figurines and an Ember merchandise cup
featured: true
authors:
- chris
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/managing-users.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/team.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- chris
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/the-editor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/writing.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- ghost
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/themes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/design.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- ghost
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/using-tags.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/tags.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- ghost
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/content/welcome.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ image: /images/welcome.jpg
imageMeta:
attribution:
attributionLink:
alt:
featured: true
authors:
- ghost
Expand Down