fix possible panic in test mode#369
Merged
eminence merged 1 commit intoMay 7, 2026
Merged
Conversation
It's possible some values in /proc/meminfo would be abnormally big which would overflow the multiply calculation. Didn't find related link on Internet but my Ubuntu 24.04 once showed incorrect SwapFree size which caused panic in procfs. MemTotal: 32405976 kB MemFree: 2062608 kB MemAvailable: 5264828 kB Buffers: 78156 kB Cached: 6070016 kB SwapCached: 0 kB Active: 8976496 kB Inactive: 17864952 kB Active(anon): 8207228 kB Inactive(anon): 15150596 kB Active(file): 769268 kB Inactive(file): 2714356 kB Unevictable: 1696048 kB Mlocked: 112 kB SwapTotal: 67108860 kB SwapFree: 18446744073708600176 kB ...
Owner
18000 exabytes sure is a lot of swap :) This change looks good to me, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible some values in /proc/meminfo would be abnormally big which would overflow the multiply calculation.
Didn't find related link on Internet but my Ubuntu 24.04 once showed incorrect SwapFree size which caused panic in procfs.