fix visual tests - #115
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The changes are small, self-contained, and directly improve determinism of visual snapshots without altering production behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR stabilizes Playwright visual regression tests by making time-dependent UI rendering deterministic, so snapshots don’t drift as real time advances.
Changes:
- Documented the coupling between
e2e/seed.sqlflight dates and the visual test “fake now” value. - Added a shared
FIXED_NOWand pinned the browser clock in the Playwright fixture for all visual tests. - Disabled Leaflet tile fade-in in tests to avoid blank map screenshots when the clock is fixed.
File summaries
| File | Description |
|---|---|
| e2e/seed.sql | Adds guidance to keep seeded flight dates aligned with the visual tests’ pinned browser clock. |
| e2e/fixtures.ts | Pins browser time via FIXED_NOW and forces Leaflet tiles opaque to keep map snapshots reliable. |
Review details
- Files reviewed: 2/10 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.