Conversation
emersion
force-pushed
the
keulim
branch
13 times, most recently
from
dae1247 to
38cb4e3
Compare
emersion
force-pushed
the
keulim
branch
4 times, most recently
from
12d70cf to
5917cd3
Compare
vilhalmer
left a comment
vilhalmer
left a comment
There was a problem hiding this comment.
Code lgtm. I tested with several random large PNG files I had laying around, as well as every unique format I had in /usr/share/icons. Everything worked except grayscale and one icon that crashed. Discussed in IRC, both were issues in keulim rather than mako.
| [wrap-git] | ||
| url = https://gitlab.freedesktop.org/emersion/keulim.git | ||
| revision = HEAD |
There was a problem hiding this comment.
Need to update the README to replace gdk-pixbuf in the dependency list. Not sure if we also want to add meson subprojects download to the beginning of the manual build steps to let it fetch the repo, or if there's another mechanism you prefer to recommend? Should at least note that icons will be automatically disabled during setup if the user doesn't take some step to grab keulim first.
I'm not really sure why meson subprojects update considers keulim "not used" before the first build even if -Dicons=enabled is passed during setup/configure. I haven't worked with subprojects before.
gdk-pixbuf is being sunset. keulim is a simple replacement: https://gitlab.freedesktop.org/emersion/keulim
2 participants
gdk-pixbuf is being sunset. keulim is a simple replacement: https://gitlab.freedesktop.org/emersion/keulim