Skip to content

Make vocabulary verification independent of embedding downloads #75

Description

@hwesterb

Problem

A cold-cache run of both the full test suite and python scripts/verify_vocabulary_change.py attempts to download sentence-transformers/all-MiniLM-L6-v2 while rebuilding or pulling the real vocabulary. With network unavailable, the real-vocabulary pull test fails and deterministic reconstruction aborts, even though embeddings are not part of pattern identity or hash verification.

This was reproduced while reviewing PRs #69-#73 on 2026-07-19. After allowing the model download once, 390 tests and the full 453-pattern verification workflow passed.

Why it matters

The canonical contributor/CI workflow should prove vocabulary determinism without depending on an external model host or a warm user cache. The current dependency adds avoidable latency and a third-party failure mode to semantic verification.

Acceptance criteria

  • python scripts/verify_vocabulary_change.py succeeds with an empty model cache and outbound network blocked.
  • The real-vocabulary pull integration test does not contact an external model host.
  • Production search embeddings remain unchanged; any deterministic stand-in or embedding bypass is scoped to reconstruction/test paths.
  • Add a regression test that fails if the verification path requests a model download.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions