fix #22#23
Conversation
embray
left a comment
embray
left a comment
There was a problem hiding this comment.
Thank you very much for the fixes. Iirc this also fixed a second issue that I think has been requested to specify the heap size.
I guess it will break with older GAP versions but that is maybe not so important as GAP users don't tend to linger on old versions for so long.
I'll need to update the CI at some point and also bump the supported CPython versions but LGTM otherwise.
| return CloseOutput(&output); | ||
| } | ||
| """ | ||
| UInt GAP_OpenOutputStream(Obj stream) |
There was a problem hiding this comment.
Why is this a string? Is this a Cython trick I forgot?
|
oh shoot i just reverted the #18 memory fix because the tests failed! Would you like me to put it back? specify gap's heap size in the gap initializer like
where gap_memory is the integer valued heap size in megabytes |
2 participants
I made MakeStringWithLen non-static, and changed the type of the first variable from char to const char.
I replaced MarkBag with GAP_MarkBag from libgap.
I passed dummy variables to OpenOutputStream and CloseOutput.