Skip to content

Fix decode_reservation_hex docstring: param is half-°C, not 20°F offset #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eman merged 2 commits into from
Jul 23, 2026
Merged

Fix decode_reservation_hex docstring: param is half-°C, not 20°F offset #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddedbc1
Fix decode_reservation_hex docstring: param is half-°C, not a 20°F of…
eman Jul 23, 2026
7c4e7c7
Fix 'minute' vs 'min' key mismatch in decode_reservation_hex example
eman Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nwp500/encoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ def decode_reservation_hex(hex_string: str) -> list[dict[str, int]]:
- Byte 2: hour (0-23)
- Byte 3: minute (0-59)
- Byte 4: mode (operation mode ID)
- Byte 5: param (temperature offset by 20°F)
- Byte 5: param (target temperature, half-degrees Celsius; °C = param/2)

Args:
hex_string: Hexadecimal string representing reservation data
Expand All @@ -355,7 +355,7 @@ def decode_reservation_hex(hex_string: str) -> list[dict[str, int]]:

Examples:
>>> decode_reservation_hex("013e061e0478")
[{'enable': 1, 'week': 62, 'hour': 6, 'minute': 30, 'mode': 4, 'param':
[{'enable': 1, 'week': 62, 'hour': 6, 'min': 30, 'mode': 4, 'param':
120}]
"""
data = bytes.fromhex(hex_string)
Expand Down
Loading