Add customization rustic-lsp-check-command#125
Merged
Conversation
This option can be set to "clippy", for example, to have Eglot report "cargo clippy" diagnostics via Flymake instead of Flycheck.
| (list :detachedFiles | ||
| (vector (file-local-name (file-truename buffer-file-name))))) | ||
| (list :check | ||
| (list :command rustic-lsp-check-command)))) |
Contributor
There was a problem hiding this comment.
I do not use eglot. What the purpose of this change? in the previous code, if the conditions don't match we will just return the empty object. However in the revised version we will always return the :check object. Is that intended?
Contributor
Author
There was a problem hiding this comment.
Yes, that is intentional. The :check field specifies the checker command to use. I've made the defcustom's default be the same as rust-analyzers so users shouldn't see any behavior change with this
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option can be set to "clippy", for example, to have Eglot report
"cargo clippy" diagnostics via Flymake instead of Flycheck.