Repository navigation
chore(deps): bump ElsaVersion to 3.9.0-preview.5757 - #273
Merged
sfmskywalker merged 1 commit intoOct 3, 2026
Merged
Conversation
Pin core to 5ef65395 so extensions compile against dashboard per-section permission filtering (#8589). Studio stays at 3.9.0-preview.1797. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
sfmskywalker
commented
Oct 3, 2026
sfmskywalker
left a comment
Member
Author
There was a problem hiding this comment.
Elsa 3 Code Review: APPROVE + HIGH @ 9e19227
Code Review, Round 1/4
This PR is a one-line pin bump into release/3.9.0: ElsaVersion goes from 3.9.0-preview.5753 to 3.9.0-preview.5757 in Directory.Build.props. ElsaStudioVersion stays at 3.9.0-preview.1797.
What I checked
- Core pin: the feed's
Elsa.Workflows.Core 3.9.0-preview.5757nuspec gives the repository commit as5ef65395, which is the current elsa-corerelease/3.9.0tip (the #8589 merge, which skips dashboard instance-store queries withoutworkflows/instances:view). - Studio pin: the feed's
Elsa.Studio 3.9.0-preview.1797nuspec gives the repository commit as2842adf0, which is still the elsa-studiorelease/3.9.0tip, so leaving it unchanged is correct. - No stale pins: these two lines in
Directory.Build.propsare the only version pins left in the repo. - No source changes needed: nothing in ext implements a dashboard contributor or uses
DashboardContext, so the #8589 change doesn't affect ext source. - Author's test run: the build has 0 errors. Of the tests, 450 pass, 2 are skipped and 44 fail, all with
DockerUnavailableException, the same as on 5753. That's an environment limitation, not a regression.
Gate
- Greptile is waived for elsa-extensions.
- GitGuardian and CLA are green.
ubuntu-latestandsubmit-nugetwere still running when I posted this. - This approval holds only for this head. Merge once
ubuntu-latestis green, and don't push again before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
release/3.9.0is on core3.9.0-preview.5753(9bba55bd, from #271). Core published3.9.0-preview.5757(5ef65395) with elsa-core#8589: dashboard per-section permission filtering so a runtime-only caller no longer hits the instance store on overview.Change
Directory.Build.props:<ElsaVersion>3.9.0-preview.5753→3.9.0-preview.5757<ElsaStudioVersion>stays3.9.0-preview.1797DashboardProvider.#8589adds init-onlyDashboardContext.CanRead(null= unrestricted) and is binary-compatible with the existing five-parameter constructor.Verification
3.9.0-preview.5757+3.9.0-preview.1797: succeededdotnet build Elsa.Extensions.sln -c Release: 0 errorsdotnet test Elsa.Extensions.sln -c Release(net10.0). No Docker socket in this environment, so Testcontainers PostgreSQL/Mongo facts failed withDockerUnavailableException. SQLite Dapper tests passed.Failures are all
DockerUnavailableException(Mongo Testcontainers fixture + 4 Dapper PostgreSQL facts). Skips are pre-existing. No compile or dashboard-contributor breakage from#8589.