Ronydahdal/simurgh#52
Open
ronydahdal wants to merge 2 commits into
Open
Conversation
Member
|
👀
… On Mar 1, 2024, at 11:22 AM, ronydahdal ***@***.***> wrote:
@ronydahdal <https://github.com/ronydahdal> requested your review on: #52 <#52> Ronydahdal/simurgh.
—
Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7J4SIOIO27YTIPZQSD6X3YWCTN7AVCNFSM6AAAAABECBBKZGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHE4DCNJQGEYDKNY>.
You are receiving this because your review was requested.
|
jumarmartin
reviewed
Mar 1, 2024
jumarmartin
left a comment
jumarmartin
left a comment
Member
There was a problem hiding this comment.
Looks good! Let's clean this up and get it merged in :)
| psql_host = "localhost:5432" | ||
| psql_database = "postgres" | ||
|
|
||
| def main(): |
Member
There was a problem hiding this comment.
Let's move this to the bottom of the file.
Member
There was a problem hiding this comment.
Rename migrate_test.py to migrate.py.
Member
There was a problem hiding this comment.
is this necessary in this pr? I feel like this should be a different pull request (while necessary anyhow!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test file for python script to migrate MSSQL tables to PSQL.