Skip } in associative array - #16
Open
jmc-netactuate wants to merge 2 commits into
Open
Conversation
Add consumeStringUntilNotByte: it does what it says on the tin, consumes the string until it encounters a byte other than the lookingForByte. Use consumeStringUntilNotByte in consumeAssociativeArray to consume the '}' closing bracket, which is necessary when there is additional content beyond the end of a nested associative array.
It locates the first byte that isn't lookingForNot.
elliotchance
approved these changes
May 24, 2019
elliotchance
left a comment
elliotchance
left a comment
Owner
There was a problem hiding this comment.
Thank you for doing this. Your change makes perfect sense, but I cannot accept it without a unit test.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add consumeStringUntilNotByte: it does what it says on the tin, consumes the string until it encounters a byte other than the lookingForByte.
Use consumeStringUntilNotByte in consumeAssociativeArray to consume the '}' closing bracket, which is necessary when there is additional content beyond the end of a nested associative array.
This change is