fix: re-running init fails to remove tab-separated install lines - desele - #225
Open
VedantMadane wants to merge 1 commit into
Open
fix: re-running init fails to remove tab-separated install lines - desele#225VedantMadane wants to merge 1 commit into
init fails to remove tab-separated install lines - desele#225VedantMadane wants to merge 1 commit into
Conversation
…- dese - crates\cli\src\commands\init.rs: treat tab-separated install lines like space-separated Fixes eljulians#200 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 92.31% 92.27% -0.05%
==========================================
Files 42 42
Lines 23186 23192 +6
==========================================
- Hits 21405 21400 -5
- Misses 1781 1792 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eljulians
reviewed
Aug 28, 2026
eljulians
left a comment
eljulians
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot for the fix @VedantMadane ! COuld you please remove the accidentally added COMMITMSG file? After that I'll merge it right away. Thank you!
eljulians
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
re-running
initfails to remove tab-separatedinstalllines - deselected platforms keep receiving deploysChanges
Fixes #200