Update to support latest Blender + Vulkan backend#5
Open
DanLaneyDLL wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update migrates the implementation from using opengl directly--through blender's now-deprecated
bglmodule--to blender'sgpumodule, allowing it to work on both the latest versions of Blender and the new Vulkan backend available in the 4.5 alpha (at time of writing).Some caveats:
blender_imgui.py" file found in the root of the repo yet, only the one found inexamples\blender_imgui.py. It seems the one inexamplesis older, before the framerate limit PR, but for some reason I was running into errors I didn't have the time to track down on top of migrating the implementation. I'll get around to updating the root file later, and will commit those changes to the file inexamplesas it seems like that was intended to get updated.BaseOpenGLRenderer.Just didn't get around to renaming it yet, oop! I'll let you choose a different name if you want :pAlso, an adjustment was made to the following code to prevent a crash when unloading the plugin:
This PR has been tested on both the latest LTS of Blender (4.4) and the 4.5 alpha, both in OpenGL and Vulkan backends. It has only been tested on Windows, but it may work fine on Linux as well.