-
Notifications
You must be signed in to change notification settings - Fork 245
feat(web): show bot collaboration in the transcript #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
apps/web/src/components/beautiful-ui/CollaborationMarker.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { renderToString } from "react-dom/server"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { ActiveBotGlyph, CollaborationMarker } from "./CollaborationMarker"; | ||
|
|
||
| describe("collaboration transcript markers", () => { | ||
| it("shows the peer avatar in an accessible message marker", () => { | ||
| const html = renderToString( | ||
| <CollaborationMarker | ||
| action="Message from" | ||
| ariaLabel="Message from Research" | ||
| color="#14B8A6" | ||
| name="Research" | ||
| onClick={() => undefined} | ||
| />, | ||
| ); | ||
|
|
||
| expect(html).toContain('aria-label="Message from Research"'); | ||
| expect(html).toContain("rakazo-bot-avatar"); | ||
| expect(html).toContain("Research"); | ||
| }); | ||
|
|
||
| it("animates the active bot glyph from its run status", () => { | ||
| const html = renderToString( | ||
| <ActiveBotGlyph | ||
| bots={[{ botId: "research", color: "#14B8A6", status: "running" }]} | ||
| label="Research is working" | ||
| />, | ||
| ); | ||
|
|
||
| expect(html).toContain('role="status"'); | ||
| expect(html).toContain('data-working="true"'); | ||
| expect(html).toContain("rakazo-bot-avatar-ring"); | ||
| }); | ||
| }); |
37 changes: 37 additions & 0 deletions
37
apps/web/src/components/beautiful-ui/CollaborationMarker.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { BotAvatar, GroupAvatar, type GroupAvatarMember } from "@rakazo/ui-web"; | ||
| import type { ReactNode } from "react"; | ||
|
|
||
| export function CollaborationMarker({ | ||
| action, | ||
| ariaLabel, | ||
| color, | ||
| name, | ||
| onClick, | ||
| }: { | ||
| action: ReactNode; | ||
| ariaLabel: string; | ||
| color: string; | ||
| name: string; | ||
| onClick: () => void; | ||
| }) { | ||
| return ( | ||
| <button | ||
| type="button" | ||
| aria-label={ariaLabel} | ||
| onClick={onClick} | ||
| className="flex items-center justify-center gap-1.5 self-center rounded-full px-2.5 py-1 text-[13px] text-[#85858A] transition-colors hover:bg-[#161618] hover:text-[#B8B8BD]" | ||
| > | ||
| <span>{action}</span> | ||
| <BotAvatar color={color} size={16} /> | ||
| <span dir="auto">{name}</span> | ||
| </button> | ||
| ); | ||
| } | ||
|
|
||
| export function ActiveBotGlyph({ bots, label }: { bots: GroupAvatarMember[]; label: string }) { | ||
| return ( | ||
| <div role="status" aria-label={label} className="flex min-h-10 items-center px-1"> | ||
| <GroupAvatar members={bots} size={28} /> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a bot-to-bot marker is rendered,
self-centerhas no effect because the button's direct message wrapper is neither flex nor grid, causing the marker to remain at the transcript's inline start instead of appearing centered.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!