Packaging prebuilt-feature sources into own Maven project - #21
Merged
Ivo Horák (horakivo) merged 13 commits intoAug 4, 2026
Merged
Conversation
Signed-off-by: Jaroslav Tulach <jaroslav.tulach@apidesign.org>
Collaborator
Author
|
Jaroslav Tulach (JaroslavTulach)
force-pushed
the
jtulach/MavenProjectsForJavaClasses
branch
from
August 3, 2026 12:05
332aff3 to
161b81c
Compare
Signed-off-by: Jaroslav Tulach <jaroslav.tulach@apidesign.org>
Jaroslav Tulach (JaroslavTulach)
force-pushed
the
jtulach/MavenProjectsForJavaClasses
branch
from
August 3, 2026 12:13
161b81c to
35d5f0e
Compare
Signed-off-by: Jaroslav Tulach <jaroslav.tulach@apidesign.org>
…avenProjectsForJavaClasses
Collaborator
Author
|
With ff14370 the Mac OS & Windows builds are green and others are likely to follow. Ivo Horák (@horakivo) please review. Another CI run after merge with |
Collaborator
Author
There was a problem hiding this comment.
All code changes are done in this native Maven project and its subprojects. As such it should be pretty easy to merge with up stream easily. The differences against current upstream are shown here:
elide/native-maven$ git diff -r 49865f242b422cc950b9c0416dd7c2cc907c8a78...jtulach/MavenProjectsForJavaClasses | grep ^diff | grep -v examples/
diff --git .github/workflows/release-spring-nmvn.yml .github/workflows/release-spring-nmvn.yml
diff --git .gitignore .gitignore
diff --git .mvn/wrapper/maven-wrapper.properties .mvn/wrapper/maven-wrapper.properties
diff --git benchmark-nmvn-examples.sh benchmark-nmvn-examples.sh
diff --git build-nmvn-catalog.sh build-nmvn-catalog.sh
diff --git build-nmvn-for-pom.sh build-nmvn-for-pom.sh
diff --git build-nmvn-generic.sh build-nmvn-generic.sh
diff --git build-nmvn-prebuilt.sh build-nmvn-prebuilt.sh
diff --git catalog/README.md catalog/README.md
diff --git catalog/catalog.json catalog/catalog.json
diff --git catalog/resolve_boot_catalog.py catalog/resolve_boot_catalog.py
diff --git graal-issue-crema-static-fields.md graal-issue-crema-static-fields.md
diff --git mvnw mvnw
diff --git mvnw.cmd mvnw.cmd
diff --git native/pom.xml native/pom.xml
diff --git native/prebuilt-feature/pom.xml native/prebuilt-feature/pom.xml
diff --git native/prebuilt-feature/src/main/java/nmvn/NmvnLauncher.java native/prebuilt-feature/src/main/java/nmvn/NmvnLauncher.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginConfigurationModule.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginConfigurationModule.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginDescriptorCache.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginDescriptorCache.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginRealmCache.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginRealmCache.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginRealms.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltPluginRealms.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltReflectionDemand.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltReflectionDemand.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltReflectionFeature.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltReflectionFeature.java
diff --git native/prebuilt-feature/src/main/java/nmvn/PrebuiltRoutingLog.java native/prebuilt-feature/src/main/java/nmvn/PrebuiltRoutingLog.java
diff --git native/prebuilt-feature/src/main/resources/META-INF/sisu/javax.inject.Named native/prebuilt-feature/src/main/resources/META-INF/sisu/javax.inject.Named
diff --git native/sanitize/pom.xml native/sanitize/pom.xml
diff --git native/sanitize/src/main/java/org/apache/maven/sanitize/SanitizeRealmJars.java native/sanitize/src/main/java/org/apache/maven/sanitize/SanitizeRealmJars.java
diff --git nmvn nmvn
diff --git pom.xml pom.xml
diff --git reflection-min/reachability-metadata.json reflection-min/reachability-metadata.json…avenProjectsForJavaClasses
Ivo Horák (horakivo)
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current layout of sources is really hard to operate on from an IDE. Not having sources organized into a project is surprising. The official build tool for this repository is Maven. Hence this PR package the sources into a Maven project with proper dependencies set. With these changes, I can open the sources in my IDE:
All dependencies are properly recognized.
TODO
build-nmvn-prebuilt.shaccordingly