Fix: CSV export file missing IP column - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
CSV exports were missing the IP column entirely. The fix ensures IP data is included in exports when the setting permits collection, addressing data completeness in audit logs.
2. What Changed (Where)
add_export_ip_column()private method that conditionally inserts IP column after source column (respecting IP collection settings)3. How It Works
When exporting, the code retrieves columns from the list table, then calls
add_export_ip_column()which:'no-collect-ip')Existing
prep_row()already populates$row['ip']from$item->hist_ip, so no data flow changes needed.4. Risks
Low risk. Settings check prevents exporting when collection disabled. Column insertion is append-only (doesn't mutate existing columns). Test coverage validates three placement scenarios, though integration test with actual CSV generation would strengthen confidence.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how