Tweak: Added more escaping - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Security hardening pass to enforce output escaping and input sanitization across the plugin, elevating
EscapeOutputviolations from warnings to CI failures.2. What Changed (Where)
aryo-activity-log.phpesc_html()class-aal-activity-log-list-table.phpesc_attr(),esc_html()to printf outputs, removed array-building patternclass-aal-admin-ui.phpesc_html_x()), sanitized$_REQUEST['page']class-aal-api.php$_SERVERIP address access withsanitize_text_field()class-aal-maintenance.phpwp_die()message withesc_html__()class-aal-settings.phpruleset.xmlWordPress.Security.EscapeOutputan error; warnings remain for other Security rulesbin/install-wp-tests.sh,.github/workflows/3. How It Works
Output escaping now applied at echo/printf points using context-aware functions (
esc_html()for text,esc_attr()for attributes,esc_url()for URLs). User input sanitized at entry (sanitize_text_field(),sanitize_key()). Ruleset enforces via CI—EscapeOutput failures block merge, other Security sniffs remain warnings pending debt resolution.4. Risks
Low. Changes are additive escaping with no logic alterations. Download retry logic may mask transient failures if too aggressive. Settings page removed notifications tab UI without confirming feature deprecation—verify no legacy configs depend on that tab visibility.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how