WindowMenu: Fix move/resize actions - #2896
Merged
Merged
Conversation
leolost2605
force-pushed
the
leolost/fix-move-resize
branch
from
August 12, 2026 16:32
0f230a0 to
b1ae37c
Compare
leolost2605
force-pushed
the
leolost/fix-move-resize
branch
from
August 12, 2026 16:35
b1ae37c to
097ff00
Compare
lenemter
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that we didn't provide a device when calling
window.begin_grab_op.While here I used the opportunity to move the logic to the WindowMenuManager. Since there we now know for which window we are showing the window menu we don't have to do the workaround with set_grab_trigger and instead can begin the grab op immediately.
This brings the little UX improvement that now after you click the move menu item your cursor immediately jumps to the center of the window and becomes the move cursor whereas with the old version (if it would work) it would only do that once you move the cursor a bit which might be confusing for users.
Since I don't think anybody else uses these actions via dbus I deprecated them and removed the related code from window manager.