MultitaskingView: Only grab focus on ws switch if we are open - #2894
Merged
Conversation
A commit can happen when we are not open anytime that a workspace was reordered, added or removed. In those cases we don't want to grab focus because that will cause the focused window to stop receiving keyboard input. A particular case where this was a problem was when moving windows via a gesture or the keyboard shortcut. There when the animation is over we call thaw_remove on the workspace manager and because a window was moved from a workspace chances are high we will get a new one or one will be removed. In that case the window would immediately stop receiving keyboard input even though it still appears focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A commit can happen even when we are not open anytime that a workspace was reordered, added or removed. In those cases we don't want to grab focus because that will cause the focused window to stop receiving keyboard input.
A particular case where this was a problem was when moving windows via a gesture or the keyboard shortcut. There when the animation is over we call thaw_remove on the workspace manager and because a window
was moved from a workspace chances are high we will get a new one or one will be removed. In that case the window would immediately stop receiving keyboard
input even though it still appears focused.
Fixes #2884