Use DBusMenuModel and DBusActionGroup for the window menu - #2893
Conversation
|
@lenemter this is what I meant in #2508 (comment)
Also I think actions is a very good fit here since then, if we want to support plugin menu items, we don't have to deal with callbacks which often lead to memory leaks but can just provide an action and a label and we are done. |
caedcd9 to
183cfad
Compare
877f06a to
fb99c84
Compare
lenemter
left a comment
There was a problem hiding this comment.
This breaks move/resize menu items. Probably because when they're pressed, the gala-daemon window is focused. Maybe wrap on_move / on_resize into Idle for now, will that work?
They are unfortunately already broken on main (at least for me). I double checked with this PR and set_grab_trigger is being called with the correct window so ig there is something wrong in set_grab_trigger. I would leave that to a follow up if that's ok |
fb99c84 to
1a6ae2d
Compare
lenemter
left a comment
There was a problem hiding this comment.
Code looks good. Thanks for taking on this :)
1a6ae2d to
20035ad
Compare
Currently we just pass the actions to the WindowManager but in a follow up we could remove perform_action (or at least most of it) from there and handle it directly in the WindowMenuManager.