Add a workflow that checks for missing and invalid files in POTFILES - #2888
Merged
Conversation
leolost2605
force-pushed
the
leolost/potfiles-test
branch
4 times, most recently
from
August 10, 2026 17:20
03a84ee to
67d9c44
Compare
Member
|
Should we not just integrate this into our gettext action? |
leolost2605
force-pushed
the
leolost/potfiles-test
branch
from
August 10, 2026 17:21
67d9c44 to
9e33a2b
Compare
Member
Author
I'd like to get feedback about missing POTFILES/files that don't exist anymore already in the PR. That's why I added it here because I thought the gettext action isn't intended to run on pull requests. But maybe we could add a new action template that does this? |
stsdc
approved these changes
Aug 11, 2026
lenemter
reviewed
Aug 11, 2026
leolost2605
force-pushed
the
leolost/potfiles-test
branch
from
August 12, 2026 10:49
ce0f3ed to
35daac7
Compare
leolost2605
force-pushed
the
leolost/potfiles-test
branch
from
August 12, 2026 14:27
35daac7 to
588c267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always forget to update them.
This is taken from flatpak: https://github.com/flatpak/flatpak/blob/main/.github/workflows/check-potfiles.yml and the corresponding script but I simplified it a lot. I know very little bash so lmk if something looks off.
It looks for .vala, .desktop.in and .metainfo.xml.in files and if they contain _( it checks whether they are in the POTFILES
Then it looks through all POTFILES and checks if they exist
First commit adds the check and I confirmed that it fails. Second commit fixes the potfiles and now it passes.