MutterTestCase: Explicitly filter expected fatal warning - #2870
Merged
lenemter merged 1 commit intoJul 24, 2026
Conversation
leolost2605
force-pushed
the
leolost/mutter-test-case-explicitly-filter-fatal-warning
branch
from
July 23, 2026 17:32
ece6469 to
881663b
Compare
lenemter
approved these changes
Jul 24, 2026
lenemter
deleted the
leolost/mutter-test-case-explicitly-filter-fatal-warning
branch
July 24, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we ignore all fatal warnings but that's not what we want. We only want to ignore a specific fatal warning and make sure unexpected fatal warnings will still fail the tests. This required a fix for a test that only passed because a fatal warning was ignored.
The implementation also makes sure to allow custom filtering of more fatal warnings by overriding a virtual method.