PiP: Mask window - #2143
Open
lenemter wants to merge 13 commits into
Open
Conversation
lenemter
force-pushed
the
lenemter/pip-mask-window
branch
from
July 29, 2025 05:24
c76ed34 to
25069e3
Compare
lenemter
marked this pull request as ready for review
July 29, 2025 08:17
Member
Author
|
Ready for review @danirabbit This requires a new icon for confirm button, I suck at inkscape so can you make one please 🙏 |
lenemter
force-pushed
the
lenemter/pip-mask-window
branch
2 times, most recently
from
August 12, 2026 17:16
264938e to
eecac8c
Compare
lenemter
force-pushed
the
lenemter/pip-mask-window
branch
from
August 12, 2026 17:19
eecac8c to
19cca32
Compare
leolost2605
requested changes
Aug 12, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
This looks really cool!
I left some comments on the code.
There also seems to be some miscalculation somewhere because when I don't select the whole window the area that is actually used as pip is offset (note that I'm using fractional scaling at 125%):
Kooha-2026-08-12-20-13-50.webm
Regarding design I personally feel like the confirm button is a bit too big but I'll leave that to UX :)
lenemter
force-pushed
the
lenemter/pip-mask-window
branch
from
August 13, 2026 09:36
87dfa3e to
f5cb414
Compare
Member
Author
|
@leolost2605 Thanks for the review. Everything should be fixed now |
leolost2605
approved these changes
Aug 13, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
Code looks good to me and everything seems to be working great! This is really cool, nicely done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Based on #1192