Skip to content

Announce debug bundle copy actions - #88

Closed
jay23606 wants to merge 1 commit into
elementalvoid:mainfrom
jay23606:pr-go/87-diagnostics-add-a-copy-control-for-the-d
Closed

jay23606 wants to merge 1 commit into
elementalvoid:mainfrom
jay23606:pr-go/87-diagnostics-add-a-copy-control-for-the-d

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Bug

Copying a debug bundle folder only wrote to the clipboard, with no confirmation or accessibility announcement.

Change

Both bundle copy actions now update one shared alert notice after a successful copy. The single notice has the alert role; unavailable bundle state leaves it unchanged.

Tested

  • cargo fmt --all -- --check
  • cargo test -p immich-sync --test diagnostics the_bundle_action_saves_an_archive_shows_its_path_and_copies_it -- --exact
  • git diff --check

The regression test failed on the base and passes with this change.

Fixes #87

@jay23606

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elementalvoid

Copy link
Copy Markdown
Owner

Hi @jay23606, thanks for the interest in contributing. But I'm going to close this rather than merging; sorry. I had an agent working on a whole set of gh issues upgrading gpui-kit 0.7.2 to 0.8.1 and adopting as many of its components as possible (issues #74–#82) last night. Its integration branch got pushed this morning so your PR is built against the old code and would need a rewrite, not a rebase/merge...

The agent filed #87 as "out of scope" for its work but didn't flag the upgrade as a dependency. And it filed without considering the correct final state which also creates a bit of overlap with #82.

I'm going to reword #87: Copying the folder path is a near-duplicate of the existing "Copy path". I'd rather have a button that opens the archive's folder path in the file manager. The goal of "copy path" was to be able to open a file manager anyway so we just make that easier.

If you'd like to take that issue, let me know on #87 and I'll leave for you.

@jay23606
jay23606 deleted the pr-go/87-diagnostics-add-a-copy-control-for-the-d branch October 31, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diagnostics: open the debug bundle archive in the file manager

2 participants