Repository navigation
Diagnostics: render the value rows as a description list #80
Description
What to build
The label-and-value rows on the diagnostics surface — server, client version, git revision, the state database facts, the per-table counts, the throughput numbers, and the last error per class — come from the kit's description list instead of two hand-written row layouts.
Acceptance criteria
- Server, state, throughput, and per-table rows render from one label/value component, and the two hand-written row layouts are gone.
- Values, element ids, and accessible names are unchanged, so the existing diagnostics tests keep passing without rewriting their assertions.
- A long value (a full path, a long error) wraps or truncates deliberately and never pushes its label off the row at the narrowest supported window.
- Both themes keep the readable contrast the card surface has today.
- The house label-and-help helper, if this ticket is the last one using it, is deleted; if the settings ticket has not landed yet, the helper stays and the follow-up is noted on that ticket.
Activity
elementalvoid commentedon Oct 31, 2026
Landed in
mainat35691b2, merged fromintegration/kit-surface(CI green at43223e2). Gate on the merged tree:cargo fmt --all -- --check,cargo clippy --workspace --all-targets -D warnings,cargo test --workspace— all clean.What the reviews changed. The two hand-written row layouts are gone; server, state, throughput, per-table and last-error rows all come from the kit's description list with a fixed label cell, so a long value can no longer push its label off the row. A 2000-character error was unbounded — a ~720 px row at 520×480 — and is now clamped to six lines with the whole text kept in the row's accessible name. The archive path's monospace font came back, and the label cell carries
Role::Term, which the kit's list does not set.Still manual. Real screen readers, macOS/Windows metrics, zoom/DPI. Filed: #89 —
field_textsurvives with real callers (logs ×5), and its two-step follow-up is written down.refactor(shell): give logs and diagnostics the settings row contract (#…