[ML] Manual test: skip ES ITs by branch name#3065
Closed
edsavage wants to merge 13 commits into
Closed
Conversation
Extend the ml-cpp-version-bump pipeline for WORKFLOW=minor (feature freeze): create the release branch from main via direct ref push, bump main to the derived next minor via PR (gradle.properties + .backportrc.json), then wait for DRA artifacts on main and the new release branch. Co-authored-by: Cursor <cursoragent@cursor.com>
Ignore GITHUB_TOKEN so a stale shell export does not override an interactive gh login session during local version bump testing. CI continues to use VAULT_GITHUB_TOKEN when gh is not pre-authenticated. Co-authored-by: Cursor <cursoragent@cursor.com>
Allow BRANCH=testing-MAJOR.MINOR for manual Buildkite runs: version rules strip the prefix while git ops use the full ref, and main bump plus DRA wait are skipped so sandbox testing does not touch production branches. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace exec-in-pipeline with if/else so WORKFLOW=minor only uploads the minor follow-up steps once, avoiding duplicate Buildkite step keys. Co-authored-by: Cursor <cursoragent@cursor.com>
Define version_bump_set_main_bump_changed before the testing-* early exit so WORKFLOW=minor sandbox runs exit 0 instead of command-not-found. Co-authored-by: Cursor <cursoragent@cursor.com>
Emit branch and PR lines as separate indented heredoc lines so the uploaded notify pipeline parses when main bump is skipped on sandbox runs. Co-authored-by: Cursor <cursoragent@cursor.com>
Buildkite executes each command array element as a separate shell line; splitting python3 and the script path started an interactive REPL and blocked the fetch-dra-artifacts step until timeout. Co-authored-by: Cursor <cursoragent@cursor.com>
Nothing uploads this script since elastic#3030 moved version-bump Slack notify to send_slack_version_bump_notification.sh in phase 2. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove duplicated helpers from bump_version.sh and validate_version_bump_params.sh so all shared functions live in one place. Co-authored-by: Cursor <cursoragent@cursor.com>
Tag bump PRs with ci:skip-es-tests and omit Java integration test pipeline uploads when that label or version-bump topic branch names are detected. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Buildkite uses author+branch/with/slashes for fork PRs; only split on the first '+' when '/' is present. Also consult GITHUB_PR_BRANCH from the PR bot. Co-authored-by: Cursor <cursoragent@cursor.com>
Subprocess tests must not inherit GITHUB_PR_BRANCH/BUILDKITE_BRANCH from the agent when asserting default ES IT scheduling behaviour. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR to verify ci:skip-es-tests branch detection. Do not merge.