Add tags to cloud OTel content package dashboards#19940
Open
giorgi-imerlishvili-elastic wants to merge 2 commits into
Open
Add tags to cloud OTel content package dashboards#19940giorgi-imerlishvili-elastic wants to merge 2 commits into
giorgi-imerlishvili-elastic wants to merge 2 commits into
Conversation
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Add a kibana/tags.yml to each cloud OTel content package so their dashboards are tagged with the cloud provider, the service, and OpenTelemetry. This makes the assets filterable and identifiable in Kibana for SAs and customers. Content packages tag assets via kibana/tags.yml (text + asset_types), mirroring the existing kubernetes_otel package; the kibana/tag/*.json saved-object form is only valid for integration packages. Relates elastic/obs-integration-team#1136
giorgi-imerlishvili-elastic
force-pushed
the
add-otel-tags-cloud
branch
from
3073258 to
f4c8711
Compare
Add `alerting_rule_template` to the asset_types in kibana/tags.yml for packages that ship alert rule templates, so those assets get the same tags as the dashboards. Relates elastic/obs-integration-team#1136
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
andrewkroh
added
Integration:aws_vpcflow_otel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add a
kibana/tags.ymlto each cloud OpenTelemetry content package so their dashboards are tagged with the cloud provider, the service, andOpenTelemetry. This makes the assets easy to filter and identify in Kibana for SAs and customers.Content packages tag their assets via
kibana/tags.yml(text+asset_types: [dashboard]), mirroring the existingkubernetes_otelpackage. Note: thekibana/tag/*.jsonsaved-object + dashboard-referencesform referenced in the issue is only valid for integration packages; the content-package spec (additionalContents: false) does not allow akibana/tag/folder, sotags.ymlis used instead. As a consequence tag colors are not settable (Kibana auto-assigns them) and dashboards are not modified.Packages in this PR (14):
aws_cloudtrail_otel,aws_ec2_otel,aws_ecs_otel,aws_elb_metrics_otel,aws_elb_otel,aws_lambda_otel,aws_rds_otel,aws_sqs_otel,aws_vpcflow_otel,aws_waf_otel,azure_activity_otel,azure_gateway_otel,gcp_audit_otel,gcp_vpcflow_otel.Checklist
changelog.ymlfile.Author's Checklist
kibana/tags.ymland applied todashboardassets on install.How to test this PR locally
elastic-package buildin each changed package.cd packages/aws_ec2_otel && elastic-package install) against a running stack.AWS/service/OpenTelemetrytags are attached, and that the dashboards are discoverable by filtering on those tags.Related issues
Screenshots